Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT: Merge the Soroban client into this package #857

Closed
wants to merge 14 commits into from
Closed

DRAFT: Merge the Soroban client into this package #857

wants to merge 14 commits into from

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Aug 15, 2023

No description provided.

@Shaptic Shaptic linked an issue Aug 15, 2023 that may be closed by this pull request
Repackage Stellar JavaScript SDK components under the @stellar/ namespace on npm. #851
Closed
@Shaptic Shaptic removed a link to an issue Aug 15, 2023
Repackage Stellar JavaScript SDK components under the @stellar/ namespace on npm. #851
Closed
@Shaptic Shaptic linked an issue Aug 15, 2023 that may be closed by this pull request
Combine Horizon and Soroban JS SDKs into a single repository #850
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 15, 2023
View reviewed changes
test/unit/horizon/claimable_balances.js
.withArgs(
sinon.match(
"https://horizon-live.stellar.org:1337/claimable_balances/00000000929b20b72e5890ab51c24f1cc46fa01c4f318d8d33367d24dd614cfdf5491072"
'https://horizon-live.stellar.org:1337/claimable_balances/00000000929b20b72e5890ab51c24f1cc46fa01c4f318d8d33367d24dd614cfdf5491072'

Check failure

Code scanning / CodeQL

Incomplete regular expression for hostnames High test

This regular expression has an unescaped '.' before 'stellar.org:1337/claimable_balances/00000000929b20b72e5890ab51c24f1cc46fa01c4f318d8d33367d24dd614cfdf5491072', so it might match more hosts than expected.
test/unit/horizon/claimable_balances.js
.withArgs(
sinon.match(
"https://horizon-live.stellar.org:1337/claimable_balances?sponsor=GDGQVOKHW4VEJRU2TETD6DBRKEO5ERCNF353LW5WBFW3JJWQ2BRQ6KDD"
'https://horizon-live.stellar.org:1337/claimable_balances?sponsor=GDGQVOKHW4VEJRU2TETD6DBRKEO5ERCNF353LW5WBFW3JJWQ2BRQ6KDD'

Check failure

Code scanning / CodeQL

Incomplete regular expression for hostnames High test

This regular expression has an unescaped '.' before 'stellar.org:1337/claimable_balance', so it might match more hosts than expected.
test/unit/horizon/claimable_balances.js
.withArgs(
sinon.match(
"https://horizon-live.stellar.org:1337/claimable_balances?claimant=GDGQVOKHW4VEJRU2TETD6DBRKEO5ERCNF353LW5WBFW3JJWQ2BRQ6KDD"
'https://horizon-live.stellar.org:1337/claimable_balances?claimant=GDGQVOKHW4VEJRU2TETD6DBRKEO5ERCNF353LW5WBFW3JJWQ2BRQ6KDD'

Check failure

Code scanning / CodeQL

Incomplete regular expression for hostnames High test

This regular expression has an unescaped '.' before 'stellar.org:1337/claimable_balance', so it might match more hosts than expected.
test/unit/horizon/federation_server_test.js
.withArgs(
sinon.match(
"https://api.stellar.org/federation?type=name&q=bob%2Astellar.org"
'https://api.stellar.org/federation?type=name&q=bob%2Astellar.org'

Check failure

Code scanning / CodeQL

Incomplete regular expression for hostnames High test

This regular expression has an unescaped '.' before 'stellar.org/federatio', so it might match more hosts than expected.
test/unit/horizon/claimable_balances.js
.withArgs(
sinon.match(
"https://horizon-live.stellar.org:1337/claimable_balances?asset=USD%3AGDGQVOKHW4VEJRU2TETD6DBRKEO5ERCNF353LW5WBFW3JJWQ2BRQ6KDD"
'https://horizon-live.stellar.org:1337/claimable_balances?asset=USD%3AGDGQVOKHW4VEJRU2TETD6DBRKEO5ERCNF353LW5WBFW3JJWQ2BRQ6KDD'

Check failure

Code scanning / CodeQL

Incomplete regular expression for hostnames High test

This regular expression has an unescaped '.' before 'stellar.org:1337/claimable_balance', so it might match more hosts than expected.
test/unit/horizon/join_test.js
.withArgs(
sinon.match(
"https://horizon-live.stellar.org:1337/operations?join=transactions"
'https://horizon-live.stellar.org:1337/operations?join=transactions'

Check failure

Code scanning / CodeQL

Incomplete regular expression for hostnames High test

This regular expression has an unescaped '.' before 'stellar.org:1337/operation', so it might match more hosts than expected.
test/unit/horizon/liquidity_pool_endpoints_test.js
return JSON.parse(JSON.stringify(js));
}

const BASE_URL = 'https://horizon-live.stellar.org:1337';

Check failure

Code scanning / CodeQL

Incomplete regular expression for hostnames High test

This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'stellar.org:1337', so it might match more hosts than expected.
This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'stellar.org:1337', so it might match more hosts than expected.
This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'stellar.org:1337', so it might match more hosts than expected.
This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'stellar.org:1337', so it might match more hosts than expected.
This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'stellar.org:1337', so it might match more hosts than expected.
This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'stellar.org:1337', so it might match more hosts than expected.
This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'stellar.org:1337', so it might match more hosts than expected.
This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'stellar.org:1337', so it might match more hosts than expected.
This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'stellar.org:1337', so it might match more hosts than expected.
This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'stellar.org:1337', so it might match more hosts than expected.
This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'stellar.org:1337', so it might match more hosts than expected.
test/unit/horizon/server_transaction_test.js
.withArgs(
sinon.match(
"https://horizon-live.stellar.org:1337/accounts/GASOCNHNNLYFNMDJYQ3XFMI7BYHIOCFW3GJEOWRPEGK2TDPGTG2E5EDW"
'https://horizon-live.stellar.org:1337/accounts/GASOCNHNNLYFNMDJYQ3XFMI7BYHIOCFW3GJEOWRPEGK2TDPGTG2E5EDW'

Check failure

Code scanning / CodeQL

Incomplete regular expression for hostnames High test

This regular expression has an unescaped '.' before 'stellar.org:1337/accounts/GASOCNHNNLYFNMDJYQ3XFMI7BYHIOCFW3GJEOWRPEGK2TDPGTG2E5EDW', so it might match more hosts than expected.
@socket-security
Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
detect-node 2.1.0 None +0 2.76 kB iliakan
webpack 5.88.1...5.88.2 None +0/-0 4.75 MB thelarkinn
@types/lodash 4.14.195...4.14.196 None +0/-0 863 kB types
eslint-plugin-prettier 4.2.1...5.0.0 None +20/-3 1.01 MB jounqin
@definitelytyped/dtslint 0.0.163...0.0.165 None +5/-6 1.33 MB definitelytyped-publisher

🚮 Removed packages: [email protected], [email protected], [email protected], [email protected]

@github-actions
Copy link

github-actions bot commented Aug 15, 2023 •
edited
Loading

Size Change: +1.51 MB (+15%) ⚠️

Total Size: 11.4 MB

Filename Size Change
dist/stellar-sdk.js 6.55 MB +931 kB (+17%) ⚠️
dist/stellar-sdk.min.js 4.88 MB +581 kB (+14%) ⚠️

compressed-size-action

@Shaptic Shaptic closed this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
soroban-scrum
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combine Horizon and Soroban JS SDKs into a single repository
1 participant
@Shaptic